search

keyboardio / KeyboardioHID

A HID library for Arduino
MIT License
34 stars 17 forks source link

Keyboard: Don't skip NONUS_POUND and CLEAR #23

Closed algernon closed 6 years ago

algernon commented 6 years ago

To be able to send NONUS_POUND and CLEAR keycodes, we need our report bitmap to support them, and not mask them over with constants. These were originally masked due to bugs in the Linux kernel, which allegedly resulted in double presses when these codes were in the report. If they are not in the report, they should not cause issues, and one may want to use the codes anyway.

Therefore, this patch removes this mask, and only the first four bits remain masked.

Fixes keyboardio/Kaleidoscope#273.

algernon commented 6 years ago

Note to self: push my findings from my worklog into the commit message.

algernon commented 6 years ago

Pushed an updated commit, with much more reasoning within it.

algernon commented 6 years ago

@obra Do you have any concerns? This fixes a legitimate issue for non-Linux users (especially international users, where NonUSPound is often used for localized keymaps), and as far as I was able to check, causes no issues under Linux either.

Would be great to have this in, so people trying their hands on localized layouts will be able to use NonUSPound.

obra commented 6 years ago

Sure, I'm willing to try it.