search

keyboardio / KeyboardioHID

A HID library for Arduino
MIT License
34 stars 17 forks source link

Mouse: Add a missing REPORT_COUNT to the horizontal wheel Usage #27

Closed algernon closed 6 years ago

algernon commented 6 years ago

Without a report count, the HID descriptor is invalid, and while Linux and Windows appear to handle that gracefully, OSX does not, and disables the entire device.

Fixes #25.

Untested, but I have a good feeling about this. If anyone with OSX handy could test if this works, that would be lovely.

gedankenexperimenter commented 6 years ago

I'll test this out as soon as I can (about three hours from now).

gedankenexperimenter commented 6 years ago

It works on macOS (High Sierra, anyway). Thanks, @algernon!

algernon commented 6 years ago

Awesome, thanks for the testing! That means that #26 and #28 are void, and this'll be the right fix. (I'll test it under Linux & Windows too, just to be sure.)

gedankenexperimenter commented 6 years ago

I tested mouse movement, buttons, and both horizontal & vertical scrolling on macOS; everything works.