search

keyboardio / KeyboardioHID

A HID library for Arduino
MIT License
34 stars 17 forks source link

Slightly more advanced modifier workarounds #44

Closed obra closed 6 years ago

obra commented 6 years ago

@algernon - have a look?

gedankenexperimenter commented 6 years ago

I had considered doing this before, but didn't bother because it didn't seem to be a problem, per @obra's original comment regarding the ChromeOS bug not being an issue when keys toggle off. It's probably not necessary to send the extra report at all when modifiers toggle off.

obra commented 6 years ago

Based on empirical testing, I found that it was necessary to prevent the misbehavior I was seeing.

On Jul 28, 2018, at 9:44 AM, Michael Richters notifications@github.com wrote:

I had considered doing this before, but didn't bother because it didn't seem to be a problem, per @obra's original comment regarding the ChromeOS bug not being an issue when keys toggle off. It's probably not necessary to send the extra report at all when modifiers toggle off.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

gedankenexperimenter commented 6 years ago

Was the misbehaviour the YYYYYyxxxxx problem you were seeing while testing the mod-flag-rollover fix?

obra commented 6 years ago

That was one of 'em, but ought to have been covered by the simpler change you suggest. I should have docced it better. ᐧ

On Sat, Jul 28, 2018 at 11:58 AM Michael Richters notifications@github.com wrote:

Was the misbehaviour the YYYYYyxxxxx problem you were seeing while testing the mod-flag-rollover fix?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/keyboardio/KeyboardioHID/pull/44#issuecomment-408628338, or mute the thread https://github.com/notifications/unsubscribe-auth/AACxaNTzrrssLw5HdgGnis3pALsBrn9qks5uLLRggaJpZM4Vi94D .