search

keyboardio / KeyboardioHID

A HID library for Arduino
MIT License
34 stars 17 forks source link

Port the library to Atmel SAMD #51

Closed algernon closed 5 years ago

algernon commented 5 years ago

The port is heavily based on NicoHood/HID's port, but it was tweaked in a few small ways for KeyboardioHID: I split it into smaller commits, and enabled host wakeup in SystemControl.

It compiles, and appears to work on real hardware too, but has seen only light testing on SAMD so far. The AVR functionality should be unaffected.

obra commented 5 years ago

"src/port/samd.cpp"

"port" seems like a weird name for that.

algernon commented 5 years ago

How about src/arch/samd.cpp? (src/port/samd.cpp is how it's called in the original)

obra commented 5 years ago

sure ᐧ

On Mon, Apr 22, 2019 at 11:09 AM Gergely Nagy notifications@github.com wrote:

How about src/arch/samd.cpp? (src/port/samd.cpp is how it's called in the original)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/keyboardio/KeyboardioHID/pull/51#issuecomment-485498052, or mute the thread https://github.com/notifications/unsubscribe-auth/AAALC2D2GVVXWU3KNLRX5WDPRX5MBANCNFSM4HHIBL4A .

algernon commented 5 years ago

Done.

Also rolled in another update, making GET_PROTOCOL and GET_IDLE work on SAMD too.

obra commented 5 years ago

Is the latest rev tested on AVR? ᐧ

On Mon, Apr 22, 2019 at 11:16 AM Gergely Nagy notifications@github.com wrote:

Done.

Also rolled in another update, making GET_PROTOCOL and GET_IDLE work on SAMD too.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/keyboardio/KeyboardioHID/pull/51#issuecomment-485500335, or mute the thread https://github.com/notifications/unsubscribe-auth/AAALC2HXRNSC66INYXCXAXDPRX6GVANCNFSM4HHIBL4A .

algernon commented 5 years ago

Yes, compiles and works fine too. At least normal keycodes come through, I haven't tested everything yet, but my gut feeling is that if anything broke, normal keycodes wouldn't work either.