search

keyboardio / Model01-Firmware

The "standard" Keyboardio Model 01 Firmware sketch.
GNU General Public License v3.0
172 stars 302 forks source link

Toggling numlock off doesn't turn it off in the OS #42

Open edanaher opened 6 years ago

edanaher commented 6 years ago

As @warewolf noted on #29, with the default firmware, turning Numlock on works as expected, but turning Numlock off turns the LEDs off and reverts back to the default layer, but leaves the Numlock state still set in the OS.

This means that any other keyboards attached will leave the Capslock LED on, and any applications that check the state of Numlock will be confused (I'm guessing there are extremely few of these - @warewolf and I both noticed this in FVWM.)

edit: Filing this as a fresh bug, since the original bug in #29 was numlock not working, not numlock not turning itself off properly.

edanaher commented 6 years ago

I submitted a PR to the relevant plugin. However, this still leaves a minor annoyance: the Model 01 "owns" numlock, in that if it's on, no other attached keyboard can turn it off. I suspect multiple keyboard use is pretty rare (except when getting started with the Model 01), so it's not a huge issue, but it does seem kind of rude.

(This follows from the way the NumPad plugin works - if the numpad is on, it forces the LED on. And this happens in the hook, which I gather is run on every "tick"; I'm still figuring out Kaleidoscope...)