obra
commented
6 years ago Hiya,
I'm sorry for the lengthy delay in my review on this one. We've made a small change to the default Model 01 sketch to push you toward modifying a 'custom' layer, rather than the default 'QWERTY' mapping. That -should- mean that a similar new PR might simply be adding a key mapping to lock to the custom layer somewhere in the QWERTY map and then back to the custom map from QWERTY. The Numpad issue is worth opening up on the Kaleidoscope-Numpad repo.
The purpose of these layers is to allow the keyboard mappings to be switched back to the stock configuration. The layers prefixed by STOCK_ are intended to be left alone when customizing. This way, if someone wants to try out your keyboard.io, you can switch it to stock mode so that the keycaps correspond to what the keys actually do.
This commit is currently imperfect, I am pushing it to get feedback. In particular, it has the following deficiencies:
The numpad light will not work in the stock configuration, because the plugin expects there to be only one numpad layer, not two.
The prog key is transparent in STOCK_QWERTY.
I did not update the comments to reflect the change. Docs would also need to change and describe the meaning of the STOCK layers.
I think it makes sense to include something like this by default once the deficiencies are resolved. Since I am used to using heavily remapped ergodox or kinesis advantage keyboards, I will also be heavily remapping my keyboard.io, and I'm sure many others will as well. The current starting configuration encourages you to overwrite the default. The problem with this is that it renders they keyboard un demoable. You'd need to reflash it with the default firmware in order to let someone try it out.
Also, I just got my hands on my keyboard io today (arrived a week or two ago). This is the first commit I've typed with it :)