search

keyboardio / Model01-Firmware

The "standard" Keyboardio Model 01 Firmware sketch.
GNU General Public License v3.0
172 stars 301 forks source link

Colormap support is incomplete #86

Closed algernon closed 5 years ago

algernon commented 5 years ago

The factory firmware includes the ColormapEffect plugin, but it does not initialize LEDPaletteTheme, without which the colormap is not usable. We should init LEDPaletteTheme too.

algernon commented 5 years ago

Fortunately, we can add it and still remain compatible with the experimental firmware shipped by Chrysalis: while the eeprom layout will be different (colormap shifts a palette down), colormap didn't work anyway, so we introduce no real breakage in practice.