search

keycloak / keycloak-benchmark

Keycloak Benchmark
https://www.keycloak.org/keycloak-benchmark/
Apache License 2.0
124 stars 66 forks source link

add a delete namesapce workflow for multi-az deploy and use it in scheduled CI workflow #845

Closed kami619 closed 3 weeks ago

kami619 commented 1 month ago

fixes #844

A working workflow run - https://github.com/kami619/keycloak-benchmark/actions/runs/9403463979/job/25900073424

Another working run with a custom project name kamesh-keycloak - https://github.com/kami619/keycloak-benchmark/actions/runs/9403617989/job/25900583038

ahus1 commented 3 weeks ago

@kami619 - I had a look in the current scripts and found this snippet:

https://github.com/keycloak/keycloak-benchmark/blob/bba9ff35d2be36c9e8795f647708d718984930ff/.github/workflows/rosa-cluster-auto-provision-on-schedule.yml#L35-L43

Looking at today's nightly run, I see that the existing pods have been created only after the "undeploy finished", so I assume it is working as expected.

Therefore I'd suggest to close this PR and the related issue as completed.

kami619 commented 3 weeks ago

@ahus1 Even though we probably do not need this now, shall I keep the workflow to delete namespaces for future use? And remove the block to delete namespaces from the scheduled workflow.

ahus1 commented 3 weeks ago

I'd be ok to keep it, not although I might not be the one to use it so much.

kami619 commented 3 weeks ago

I have adjusted the PR to reflect my last comment, please see if we can merge this one. @ahus1