search

keycloak / keycloak-benchmark

Keycloak Benchmark
https://www.keycloak.org/keycloak-benchmark/
Apache License 2.0
124 stars 66 forks source link

Enable protostream #853

Closed pruivo closed 2 weeks ago

pruivo commented 3 weeks ago

Closes #628

I have the following error with status code 500. I haven't figured out where they come from. I couldn't find any exceptions in the pod's log. 

[ERROR]   EntityReplicationTest.keycloakEntityReplicationOverCacheTest:25 » InternalServerError HTTP 500 Internal Server Error
[ERROR]   SessionExpirationTest.sessionExpirationTest:19 » InternalServerError HTTP 500 Internal Server Error

We probably need to fork the main branch before merging this one. The forked branch will keep compatibility with jboss-marshalling and KC25.

pruivo commented 2 weeks ago

Thank @pruivo, this PR looks good to me.

To the errors you see. What were you testing this against? If you tested against runner-keycloak namespace created by the nightly run, it is probably caused by the fact the testsuite currently does not work with A/A. We need to test this against A/P deployment where the testsuite is passing.

Here are the errors: https://github.com/keycloak/keycloak-benchmark/actions/runs/9559243516/job/26354830531

I will be looking at the A/A failures now.

I created a new cluster in a different namespace (keycloak + infinispan) with Route53. I was using the existing aurora DB instead of creating and populating another one. I assume it wouldn't have any impact.

mhajas commented 2 weeks ago

I suspect it can be caused by the database. It seems A/A tests leave the database in a state where some requests end up with 500. Can you please test with a different database cluster?

pruivo commented 2 weeks ago

@mhajas thanks for the tip. I'll change this to ready for review :+1: 

[INFO] Results:
[INFO] 
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO]