search

keycloak / keycloak-benchmark

Keycloak Benchmark
https://www.keycloak.org/keycloak-benchmark/
Apache License 2.0
130 stars 72 forks source link

dataset-import.sh isn't included in the binary release of keycloak-benchmark #996

Open paul-civitas opened 4 weeks ago

paul-civitas commented 4 weeks ago

Describe the bug

keycloak-benchmark-0.12-SNAPSHOT.tar.gz includes the following:

keycloak-benchmark-0.12-SNAPSHOT/bin/kcb.sh
keycloak-benchmark-0.12-SNAPSHOT/bin/kc-failover.sh
keycloak-benchmark-0.12-SNAPSHOT/bin/initialize-benchmark-entities.sh
keycloak-benchmark-0.12-SNAPSHOT/bin/kc-chaos.sh
keycloak-benchmark-0.12-SNAPSHOT/conf/README.adoc
keycloak-benchmark-0.12-SNAPSHOT/lib/keycloak-benchmark-0.12-SNAPSHOT.jar

But it doesn't include: dataset-import.sh which is a crucial piece of the puzzle. To get that script to run it you need to download the src.

Version

Keycloak 24, keycloak-benchmark 0.12-SNAPSHOT

Expected behavior

Scripts and binaries expected to be run by the user, are included with the binary distribution.

Actual behavior

Only some portion of the scripts are included.

How to Reproduce?

Try and run benchmarks without cloning down the src.

Anything else?

This is a minor issue

mhajas commented 4 weeks ago

Thank you for the report @paul-civitas. You are right, the script is missing from the release. The simplest fix would be to the same as we are doing in benchmark module and package a zip file also for dataset module that would contain both, the shell script and the jar file.

We would welcome a contribution for this so feel free to open a PR against this repository if you are willing to contribute.