search

keycloak / keycloak-nodejs-connect

Apache License 2.0
682 stars 421 forks source link

Test and develop against Nightly versions of Keycloak #364

Closed jonkoops closed 2 years ago

jonkoops commented 2 years ago

Changes needed for #359. Tests everything against Keycloak Nightly instead of a fixed version Docker image. Also includes changes to make the Quarkus the default distribution.

mposolda commented 2 years ago

@jonkoops In the test results, I can see that tests are failing due the <p class="instruction">Invalid parameter: redirect_uri</p> . Which is exactly caused by the OIDC RP-Initiated Logout changes as "redirect_uri" parameter does not work anymore with the logout in the Keycloak server LogoutEndpoint .

I guess you can cherry-pick the commit from https://github.com/keycloak/keycloak-nodejs-connect/pull/359 to this PR, so both commits are in the same PR. This should work for the tests agains Keycloak 18. WDYT?

jonkoops commented 2 years ago

No worries, I will have someone with JS knowledge take a look at the changes as well.

jonkoops commented 2 years ago

Marking this PR as ready for review. One of the tests will fail due to missing changes that will be included in #359.

jonkoops commented 2 years ago

I decided to add the changes from #359 here so we can see the full integration. Seems all the tests are passing, so I think we are good to merge.