search

keycloak / keycloak-nodejs-connect

Apache License 2.0
676 stars 421 forks source link

Missing KeycloakConfig Parameter public-client #411

Open ccravens opened 2 years ago

ccravens commented 2 years ago

Describe the bug

The KeycloakConfig typedef is defined here:

https://github.com/keycloak/keycloak-nodejs-connect/blob/cc4bb724fd3fd3fc153283d54f5868303b33418c/keycloak.d.ts#L20

However in Keycloak 18, the config JSON is being generated as such: image

Providing the public-client parameter to the KeycloakConfig object causes an error. Suggest updating the typedef to:

  interface KeycloakConfig {
    'confidential-port': string|number
    'auth-server-url': string
    'resource': string
    'ssl-required': string
    'bearer-only'?: boolean
    realm: string
    'public-client': boolean;
  }

Version

18.0.2

Expected behavior

Expectation is that KeycloakConfig contains all attributes that can be generated by the Keycloak server

Actual behavior

KeycloakConfig is missing a parameter

How to Reproduce?

Try to add the public-client parameter to a KeycloakConfig results in a compilation error

Anything else?

No response