search

keycloak / keycloak-nodejs-connect

Apache License 2.0
676 stars 421 forks source link

Remove chromedriver prod dependency? #511

Open winterec opened 9 months ago

winterec commented 9 months ago

Describe the bug

chromedriver is being installed in my production builds with pnpm and turborepo. I can see that it's listed in optionalDependencies but it seems to be installed regardless and I can't seem to deselect it or create an override in pnpm.

Could this be safely moved to devDependencies?

pnpm-lock.yaml

  /keycloak-connect@22.0.5:
    resolution: {integrity: sha512-3aTU3m/hA9to6NhC1pLK6Rv/9zqJuvmX5J5C4LkKXF64ejQk/nlUnPw2hrBky+s6eJneFQ/sCWf4OSNGsenAYw==}
    engines: {node: '>=14'}
    dependencies:
      jwk-to-pem: 2.0.5
    optionalDependencies:
      chromedriver: 119.0.1
    transitivePeerDependencies:
      - debug
      - supports-color
    dev: false

Version

22.0.5

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Anything else?

No response

jonkoops commented 9 months ago

Yeah, this should be a devDependency instead, feel free to submit a PR.