search

keycloak / keycloak-quickstarts

Apache License 2.0
1.99k stars 985 forks source link

Fix compile issues with event-store-mem example #328

Closed ahus1 closed 2 years ago

ahus1 commented 2 years ago

Closes #327

ahus1 commented 2 years ago

With this change in place, event-store-mem is no longer on the list of failed examples.

Other examples still fail, and will be fixed in other PRs.

@mhajas - as you've been involved in the original PR that included that API change, I ask you to review this PR. Thanks!

vmuzikar commented 2 years ago

One thing I was wondering about. With this QS broken, does it mean we did some breaking changes to our SPI? Was that intended?

ahus1 commented 2 years ago

Hi @vmuzikar - at first sight this is a private SPI, so we're ok to change it.

I asked @mhajas for a review here, he might add additional insights.

ahus1 commented 2 years ago

@mhajas - no worries. Getting this merged is one step to get the job back in the green, and then we'll no longer miss anything that might break.