Fix sed command to escape $

bnallapeta commented 1 year ago

Reason for PR:

Currently, the getting started with kubernetes guide does not have instructions asking the user to replace the placeholder $$VERSION$$.
Following the instructions listed will result in InvalidImageName error on the pod as it will try to pull quay.io/keycloak/keycloak:$$VERSION$$
https://github.com/keycloak/keycloak-quickstarts/issues/503

PR Description:

Fixes the sed command in the set-version.sh script to properly escape $ characters.
Ensures $$VERSION$$ placeholder in Kubernetes and OpenShift YAML files is correctly replaced with the provided new version.
Modifies openshift yaml file to use $$VERSION$$ instead of a hardcoded value.

bnallapeta commented 1 year ago

@vmuzikar ah, I didn't notice that it forked the 'latest' branch. Rebased now.

I also see that a bot has added more changes and set the version in a bunch of other files. Is this expected?

vmuzikar commented 1 year ago

Thanks for the update!

I also see that a bot has added more changes and set the version in a bunch of other files. Is this expected?

Nope, there should be only one commit – yours.

bnallapeta commented 1 year ago

@vmuzikar My bad. Its all good now. Please check.

keycloak / keycloak-quickstarts