search

keycloak / keycloak-quickstarts

Apache License 2.0
1.89k stars 968 forks source link

Where is the old authenticator example? #553

Open oculos opened 3 months ago

oculos commented 3 months ago

Describe the bug

According to this, the example should be under extensions: https://github.com/keycloak/keycloak/commit/1f772d29575e67ca86b30697a2d4088c1cdbd260

I recall seeing it there, but I can't find it anymore. Is it deprecated now?

Version

24.0.3

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Anything else?

No response

mposolda commented 2 months ago

@oculos Update: The PR to quickstarts was here https://github.com/keycloak/keycloak-quickstarts/pull/540 , however it was sent to keycloak:latest and hence it was automatically removed during the release of Keycloak 24.0.3 as correct branch for pull requests is keycloak:main .

PR is welcome to the main branch if you have a time :-) It should work with the same content as was in the https://github.com/keycloak/keycloak-quickstarts/pull/540 , but may require adding method getCredentialType() (See https://github.com/keycloak/keycloak/commit/c427e653 for the details).