search

keycloak / keycloak-quickstarts

Apache License 2.0
1.98k stars 984 forks source link

fix: Failures in ExtendAdminConsoleTest #556

Closed mabartos closed 4 months ago

mabartos commented 6 months ago

Fixes #555

@edewit @jonkoops Could you please check it? Thanks!

Is there any official documentation for the Admin Console UI SPI where it should be mentioned as well? I'm not aware of any.

It should be backported to the 24 branch, right? However, I think the fix for those compilation errors is not there as well (cc: @hmlnarik ). But didn't analyze it more.

mposolda commented 5 months ago

@mabartos There should not be PR sent to the branch latest . All PRs to quickstarts should go to branch main .

The content of branch latest is always overwritten from branch main during Keycloak release, so your changes to the branch latest would be lost if updates are done only in branch latest instead of updating branch main . We plan to update quickstarts contributon guide with mentioning this.

mposolda commented 4 months ago

Closing as I replaced it with PR https://github.com/keycloak/keycloak-quickstarts/pull/566, which is sent against correct branch main (PR to quickstarts should not be sent to branch latest as that one is always rforce-pushed during the Keycloak release with the content of latest main branch) and contains also some other fixes.