search

keycloak / keycloak-quickstarts

Apache License 2.0
1.99k stars 984 forks source link

Replace KC_URL also in keycloak.json #569

Closed mhajas closed 1 month ago

mhajas commented 4 months ago

It seems by default keycloak.json response does not have any content-type set and per docs https://github.com/bfncs/string-replace-middleware?tab=readme-ov-file#configuration string-replace-middleware does not apply string replacement in such case.

This PR changes the behavior so also keycloak.json gets KC_URL replaced and hence can be use the same way as URL in index.html.

mposolda commented 1 month ago

@jonkoops Could you please review? Feel free to close if it is already out-of-context by your latest changes.

jonkoops commented 1 month ago

@mposolda the changes for the Node.js side might still be relevant, but I believe my recent changes have made the rest no longer relevant.

mhajas commented 1 month ago

Thanks for looking into this @jonkoops. I see keycloak.json is no longer used so I am not 100% sure how to fix this now. I think we can close and leave this as is.