search

keycloak / keycloak

Open Source Identity and Access Management For Modern Applications and Services
https://www.keycloak.org
Apache License 2.0
23.35k stars 6.76k forks source link

Planning issues for 17.0.1 #10708

Closed stianst closed 2 years ago

stianst commented 2 years ago

Moved to using a project to manage backporting: https://github.com/orgs/keycloak/projects/10/views/1

DGuhr commented 2 years ago

Would love to also see these inside:

https://github.com/keycloak/keycloak-web/pull/288 / https://github.com/keycloak/keycloak-quickstarts/pull/304 -> merge the PRs for the openshift starter to work again

https://github.com/keycloak/keycloak/pull/10347 -> makes troubleshooting way easier when no write rights on dirs

https://github.com/keycloak/keycloak/pull/10665 -> fix start-dev in windows.

pedroigor commented 2 years ago

Can we also include:

abstractj commented 2 years ago

@stianst would be possible to include https://github.com/keycloak/keycloak/issues/10678 and the RESTEasy upgrade https://github.com/keycloak/keycloak/issues/9599 ?

DGuhr commented 2 years ago

@pedroigor @stianst should we do a round of checking the startup performance regressions we observed before 17.0.1 then?

stianst commented 2 years ago

@stianst would be possible to include #10678 and the RESTEasy upgrade #9599 ?

Liquibase we can include if it's merged in main, and someone from @keycloak/storage-x can confirm it is not likely to break anything

Aligning versions in RestEasy in the POM is not something for 17.0.1 for sure.

hmlnarik commented 2 years ago

@vramik @sguilhen Could any of you please confirm re the following?

Liquibase we can include if it's merged in main, and someone from https://github.com/orgs/keycloak/teams/storage-x can confirm it is not likely to break anything

sguilhen commented 2 years ago

We' ve run all the db_tests and db_migration_tests for the Liquibase PR. In addition I've manually verified that the new storage is working with the new Liquibase version. The only thing I had to do was to adjust the Liquibase initialization to prevent it from displaying messages every time a changeset is processed, but that has also been incorporated in the PR.

On Wed, Mar 16, 2022 at 1:12 PM Hynek Mlnařík @.***> wrote:

@vramik https://github.com/vramik @sguilhen https://github.com/sguilhen Could any of you please confirm re the following?

Liquibase we can include if it's merged in main, and someone from https://github.com/orgs/keycloak/teams/storage-x can confirm it is not likely to break anything

— Reply to this email directly, view it on GitHub https://github.com/keycloak/keycloak/issues/10708#issuecomment-1069303684, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACW25T4CKAVEQPMY3NULFLVAIB77ANCNFSM5QPE4XKA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

--

Stefan Guilhen

Principal Software Engineer

Red Hat https://www.redhat.com/

@.*** IM: sguilhen @RedHat https://twitter.com/redhat Red Hat https://www.linkedin.com/company/red-hat Red Hat https://www.facebook.com/RedHatInc https://www.redhat.com/

abstractj commented 2 years ago

@DGuhr FYI PR https://github.com/keycloak/keycloak/pull/10665 was closed by the author.

DGuhr commented 2 years ago

@abstractj was superseeded by https://github.com/keycloak/keycloak/pull/10805 - now with a commit message that includes the issue #. so its merged

DGuhr commented 2 years ago

Update to 2.7.5 is done via #10823, can be ticked off.