search

keycloak / keycloak

Open Source Identity and Access Management For Modern Applications and Services
https://www.keycloak.org
Apache License 2.0
21.09k stars 6.46k forks source link

Missing parameter cryptographic_binding_methods_supported in openid-credential-issuer endpoint #30458

Open ttu75 opened 3 weeks ago

ttu75 commented 3 weeks ago

Before reporting an issue

Area

oid4vc

Describe the bug

After I add "cryptographic_binding_methods_supported" in new client's attribute, I don't see this parameter in in openid-credential-issuer endpoint Look like the vaule of CRYPTOGRAPHIC_BINDING_METHODS_SUPPORTED_KEY is incorrect from this line https://github.com/keycloak/keycloak/blob/5c0dddd8372f3e39f82524d4cf0fdd48b21d3509/services/src/main/java/org/keycloak/protocol/oid4vc/model/SupportedCredentialConfiguration.java#L45

Version

25.0.0

Regression

Expected behavior

Display cryptographic_binding_methods_supported in openid-credential-issuer endpoint

Actual behavior

Missing cryptographic_binding_methods_supported parameter

How to Reproduce?

Add "cryptographic_binding_methods_supported" in new client's attribute, and check this new value is in openid-credential-issuer endpoint

Anything else?

No response

keycloak-github-bot[bot] commented 3 weeks ago

Due to the amount of issues reported by the community we are not able to prioritise resolving this issue at the moment.

If you are affected by this issue, upvote it by adding a :thumbsup: to the description. We would also welcome a contribution to fix the issue.

mposolda commented 3 weeks ago

@wistefan @francis-pouatcha @tnorimat What do you think about this one?

wistefan commented 3 weeks ago

@mposolda I'll have a look tomorrow.

wistefan commented 3 weeks ago

The issue was already solved by @francis-pouatcha in https://github.com/keycloak/keycloak/commit/d4797e04a29db387a68efc7a25f65e2ab883b84d @mposolda I think this can be closed.