keycloak / terraform-provider-keycloak

Terraform provider for Keycloak
https://registry.terraform.io/providers/mrparkers/keycloak/latest/docs
Apache License 2.0
651 stars 317 forks source link

Updated keycloak_client.go to support keycloak 22 #903

Closed wombat closed 11 months ago

wombat commented 11 months ago

RH SSO changed the ".GA" string at the end of the version to "redhat-00002" with the release of Red Hat Build of Keycloak. I added a more generic approach in case Red Hat changes the number at the end of the version string.

Sample string from the latest release: 22.0.6.redhat-00002

With the provided change we were able to run our Keycloak provisioning successfully without the following error that we see in the 4.3.1:

Error: error initializing keycloak provider
│
│   with provider["registry.terraform.io/mrparkers/keycloak"],
│   on main.tf line 7, in provider "keycloak":
│    7: provider "keycloak" {
│
│ failed to perform initial login to Keycloak: Malformed version: 22.0.6.redhat-00002
simonregn commented 11 months ago

Hi @mrparkers I have been working with @wombat on this case. Could you please have a look at this? Can this be merged and released? Thanks :)

andreas-sundstrom commented 11 months ago

Great work guys! This would help our team out a lot! 👍⭐👍

johnalmm commented 11 months ago

Same for my team!

mrparkers commented 11 months ago

Sorry for the late review on this. This looks good to me, although I can't verify myself since I don't have access to RedHat SSO. But I'll trust you guys on this one.

Thanks for the PR!

simonregn commented 11 months ago

Any plans to release this soon?

johnalmm commented 11 months ago

Great work! Yes, getting this to the terraform registry would be golden.

johnalmm commented 10 months ago

@mrparkers Do you have any reason for not doing a new release on the terraform registry with this feature? Could we help out with anything to help make it happen?