keycloakify / keycloakify-starter-angular

🔑 Keycloakify Angular Projects Starter Template for Webpack
6 stars 1 forks source link

Use the canonical approach and propagate the type #13

Closed garronej closed 4 weeks ago

kathari00 commented 1 month ago

@luca-peruzzo this approach has the advantage that it is typed better as messages are being suggested when using it. What do you think about that?

garronej commented 4 weeks ago

Hi @kathari00,

I’ve updated this PR to use Keycloakify 11.

Since this is actually the first time I touch an Angular codebase, there might be small mistakes, but I’m confident in the overall validity of the proposed changes.

I’ve removed the i18n-theme-defined-messages.provider.ts file, as its functionality is now handled by the src/keycloak-theme/login/i18n.ts file (see the comments where I’ve included relevant links).

Things that you might want to know to tackle on your end:

Let me know if you have any questions or concerns.

Best,