search

keycloakify / keycloakify-starter-angular

🔑 Keycloakify Angular Projects Starter Template for Webpack
6 stars 1 forks source link

Code Refactor #6

Closed luca-peruzzo closed 1 month ago

luca-peruzzo commented 1 month ago

@kathari00 Hi finally here it is the refactor. Sorry for wasting your time ( :sweat: ) with the previous one, now it works in the keycloak docker container too (tested v23 and v25). If you have any concerns about this PR please let me know. Thanks for your time!

[I will leave this PR in draft untill your approval]

kathari00 commented 1 month ago

Hi thanks for checking in. Does the navigation work as well?

What about the locale mode does it start up?

luca-peruzzo commented 1 month ago

Yes for both, there is only some warnings on the keycloakify generated assets (some .eot fonts missing) but it compiles and shows the page

luca-peruzzo commented 1 month ago

I want to leave the pipe call wrapped in () as it makes it easier to read for me.

Thanks for polishing this.

What do you mean? could you please reference a piece of code where this wrapping is missing?

kathari00 commented 1 month ago

I want to leave the pipe call wrapped in () as it makes it easier to read for me. Thanks for polishing this.

What do you mean? could you please reference a piece of code where this wrapping is missing?

I want to have it like this [class]="('sth' | KClass)"

Instead of [class]="'sth' | KClass"

luca-peruzzo commented 1 month ago

I want to leave the pipe call wrapped in () as it makes it easier to read for me. Thanks for polishing this.

What do you mean? could you please reference a piece of code where this wrapping is missing?

I want to have it like this [class]="('sth' | KClass)"

Instead of [class]="'sth' | KClass"

Ok, I think it is an automatic correction of prettier cause brackets aren't necessary. I could check of it is possible to disable this rule