Allow draft artifacts to be downloaded by admins

keygen-sh / keygen-api

Keygen is a fair source software licensing and distribution API built with Ruby on Rails. For developers, by developers.

https://keygen.sh

Other

824 stars 53 forks source link

Allow draft artifacts to be downloaded by admins #740

Closed mgd722 closed 1 year ago

mgd722 commented 1 year ago

To reproduce:

make a draft release
upload an artifact
navigate to that artifact's page and click "Download"
you will arrive at an API endpoint displaying json

Solutions:

disable download button on artifacts when their release is a draft
allow artifact downloads to work with draft releases

I'd lean towards the latter. It'd be useful to be able to review the content of a draft release before publishing it, especially if you weren't the author of the release.

ezekg commented 1 year ago

The ability to download draft artifacts is now available in Keygen Cloud.