I'd like to consolidate the following validation codes into a NOT_ACTIVATED code:
FINGERPRINT_SCOPE_MISMATCH
NO_MACHINES
NO_MACHINE
Since this is literally what we recommend, and do everywhere — treating these codes as the same signal — it'd be much easier if they were the same signal. Having 3 different validation codes essentially meaning the same thing is confusing.
We can do this in a backwards compatible way, using request migrations:
Rename code NOT_ACTIVATED->FINGERPRINT_SCOPE_MISMATCH for validations where meta.code == NOT_ACTIVATED and data.relationships.machines.meta.count > 0.
Rename code NOT_ACTIVATED->NO_MACHINES for validations where meta.code == NOT_ACTIVATED, data.attributes.floating == true and data.relationships.machines.meta.count == 0.
Rename code NOT_ACTIVATED->NO_MACHINE for validations where meta.code == NOT_ACTIVATED, data.attributes.floating == false and data.relationships.machines.meta.count == 0.
Doing this would remove a lot of confusion, and various unintentional errors e.g. forgetting to activate on FINGERPRINT_SCOPE_MISMATCH when writing the blessed validation->activation flow.
I'd like to consolidate the following validation codes into a
NOT_ACTIVATEDcode:FINGERPRINT_SCOPE_MISMATCHNO_MACHINESNO_MACHINESince this is literally what we recommend, and do everywhere — treating these codes as the same signal — it'd be much easier if they were the same signal. Having 3 different validation codes essentially meaning the same thing is confusing.
We can do this in a backwards compatible way, using request migrations:
NOT_ACTIVATED->FINGERPRINT_SCOPE_MISMATCHfor validations wheremeta.code == NOT_ACTIVATEDanddata.relationships.machines.meta.count > 0.NOT_ACTIVATED->NO_MACHINESfor validations wheremeta.code == NOT_ACTIVATED,data.attributes.floating == trueanddata.relationships.machines.meta.count == 0.NOT_ACTIVATED->NO_MACHINEfor validations wheremeta.code == NOT_ACTIVATED,data.attributes.floating == falseanddata.relationships.machines.meta.count == 0.Doing this would remove a lot of confusion, and various unintentional errors e.g. forgetting to activate on
FINGERPRINT_SCOPE_MISMATCHwhen writing the blessed validation->activation flow.