Closed ezekg closed 4 months ago
When we roll this out, should we set the DEFAULT_API_VERSION
to v1.5 so we have ample time to run the permission tasks? Then once things are ready and documentation has been updated, we can start putting new accounts into v1.6.
As long as docs are updated, the migrations shouldn't take too long. I doubt a new account is going to swoop in, fully onboarded, trying to utilize the new endpoints within the time we deploy and the time our migrations complete.
Skipping because this just adds an unnecessary step.
CI is failing here and on master because a Ruby 3.2.3 image isn't available yet.
Will re-run later.
Currently waiting on audit and review of union_of
.
This pull request was deployed and Sentry observed the following issues:
Api::V1::UsersController#show
View IssueApi::V1::ProfilesController#me
View IssueApi::V1::UsersController#index
View IssueApi::V1::ProfilesController#me
View IssueApi::V1::Licenses::Actions::ValidationsControll...
View IssueDid you find this useful? React with a 👍 or 👎
Renamed #768. Closes #534. TL;DR: licenses had-one user, now licenses have-many users.
Prerequisites
user
validation scope to look atLicense#users
.Addowner
validation scope? (May be too ambiguous with license vs machine owner.)License#user
toLicense#owner
.user
relationship toowner
in user serializer.users
relationship to license serializer.data.relationships.owner
todata.relationship.user
for licenses (with updated links).RenameNot needed with v1x5 module.license.user.updated
webhook event tolicense.owner.updated
?Set default API version to v1.5 until post-deploy checklist is complete.Workaround in 7a61cb0aab677b33effb0da6378b4f116b92cde2.union_of
.Pre-deploy
license.users.attached
,license.users.detached
,license.owner.updated
,machine.owner.updated
event types.license.users.attach
,license.users.detach
,license.owner.update
,machine.owner.update
permissions.Post-deploy
Renamelicenses.user_id
tolicenses.owner_id
? (May want to do this during our next maintenance window?)RenameNot needed with v1x5 module.license.user.update
permission tolicense.owner.update
?Set default API version to v1.6.Workaround in 7a61cb0aab677b33effb0da6378b4f116b92cde2.union_of
to a gem.