keygen-sh / keygen-api

Keygen is a fair source software licensing and distribution API built with Ruby on Rails. For developers, by developers.
https://keygen.sh
Other
699 stars 40 forks source link

Remove non-essential Rack Attack rate limiters #849

Closed ezekg closed 1 month ago

ezekg commented 1 month ago

Most of this should be handled at the WAF level. We should add a single rate limiter for an upper bound on requests per-ip, e.g. RACK_ATTACK_MAX_RPM and RACK_ATTACK_MAX_RPS.

Other than that, we should remove the burst rate limiters, as well as account level rate limiters and shedders. This will reduce needless strain on Redis per-request.

Security-related rate limiters e.g. on password reset and MFA, should stay.

While we're here, we should also tackle #724.