Ref/regex parse - Githubissues

keyko-io / filecoin-verifier-tools

Javascript implementation of a HAMT using ipld

Apache License 2.0

6 stars 5 forks source link

Ref/regex parse #155

Closed huseyincansoylu closed 1 year ago

huseyincansoylu commented 1 year ago

ldn refactoring

refactored parser functions
refactored test functions / added new test
refactored and added sample files for testing
refactored large-issue-parser js
refactored module import/export
refactored folder structure
added uuid (parser and also test for it)

huseyincansoylu commented 1 year ago

when shipping this , we should be sure that we adjust the ldn => https://github.com/keyko-io/filecoin-large-clients-onboarding-bot/issues/127

huseyincansoylu commented 1 year ago

Discussion : Datacap Request Trigger comment

example link : https://github.com/filecoin-project/filecoin-plus-large-datasets/issues/1476#issuecomment-1360221436

here when you click the link you will see the template Simon's use , he uses "*" (star symbol) which is different than in the verifiers tools repo samples because we use "#" instead "*".

! before shipping this we should fix that

if it should be "*" , then i need to change the logic and regex inside function.

fabriziogianni7 commented 1 year ago

@huseyincansoylu we should say Simon to use the version with "#" after the doc with all the comment template is done, we can reference it to them

huseyincansoylu commented 1 year ago

@huseyincansoylu we should say Simon to use the version with "#" after the doc with all the comment template is done, we can reference it to them

okay i sent message in the slack channel.

huseyincansoylu commented 1 year ago

when we ship regex-ref then afterwards we should merge this => https://github.com/keyko-io/filecoin-large-clients-onboarding-bot/pull/133

@fabriziogianni7