keylase / nvidia-patch

This patch removes restriction on maximum number of simultaneous NVENC video encoding sessions imposed by Nvidia to consumer-grade GPUs.
3.49k stars 272 forks source link

Suggestions: Date Driver Update Released / Date Patch Added Columns / Autoupdate Improvement / Error Message Improvement / File Ownership Merge Request #854

Open Spaatz1402 opened 1 week ago

Spaatz1402 commented 1 week ago

Hello,

I love your tool but find it a bit daunting to determine when I last applied the patch and would like to save some time researching all of that before simply applying the latest patch.

Here are some suggestions I feel would be good for your application:

1.) The error message when trying to reapply the patch could be updated to indicate the patch has already been applied. 2.) The file ownership rights issue should be pushed to the main version because nearly all files I'm getting from NVidia these days are locked for editing until I take ownership and thus this installer fails. I'm using a forked version of this tool that has the functionality required. Perhaps merge that functionality? Win_1337_Apply_Patch_v2.1_By_DFoX 3.) The documentation screen / table which lists the patches, driver link, version number, etc. could have two additional columns: A.) Date patch made available B.) Date of Driver Release 4.) Adding an automatic update feature to the application to identify the correct patch needed, download the update from GitHub and apply it to the driver would be ideal.

Thanks for taking the suggestions into consideration and thanks for your work!

ramhaidar commented 4 days ago

Thank you for your suggestions @Spaatz1402! Here is my response regarding the suggestions you provided:

  1. This is a great idea, and I will implement it in the forked version of my application if I have some free time later.
  2. Regarding your merge suggestion, I have actually submitted a PR to the main Win_1337_Apply_Patch repository, and Deltafox79 has merged it into the main master branch. However, it seems that they either forgot or were too busy to upload the latest release of the modified code. So, as long as they haven't updated it, you can use a forked version with updated functionality to handle it.
  3. and 4. I have no comments on these points; I will leave them to the other maintainers for further discussion.