Fix `ContextFactory.context` function: it should not return an Array when all the contexts are not `applicable?`

[guizmaii]

Hi @jeremywadsack ,

In my test suite, I have the following error:

undefined method `namespace' for #<Array:0x000000000a5f7648>
shared/bundle/ruby/2.3.0/gems/resque-kubernetes-1.3.0/lib/resque/kubernetes/jobs_manager.rb:73:in `build_client'
shared/bundle/ruby/2.3.0/gems/resque-kubernetes-1.3.0/lib/resque/kubernetes/jobs_manager.rb:66:in `client'
shared/bundle/ruby/2.3.0/gems/resque-kubernetes-1.3.0/lib/resque/kubernetes/jobs_manager.rb:57:in `jobs_client'
shared/bundle/ruby/2.3.0/gems/resque-kubernetes-1.3.0/lib/resque/kubernetes/jobs_manager.rb:79:in `finished_jobs'
shared/bundle/ruby/2.3.0/gems/resque-kubernetes-1.3.0/lib/resque/kubernetes/jobs_manager.rb:22:in `reap_finished_jobs'
bundle/ruby/2.3.0/gems/resque-kubernetes-1.3.0/lib/resque/kubernetes/job.rb:91:in `before_enqueue_kubernetes_job'

[jeremywadsack]

@guizmaii, I'm interested in knowing more about different contexts for authentication. Is this failing just because your test environment is not authenticated in anyway? (And if so, doesn't that lead to further failures because jobs_client is now nil?)

[guizmaii]

@jeremywadsack With this new version, now I have the following error: undefined method 'get_jobs' for nil:NilClass

[guizmaii]

Is this failing just because your test environment is not authenticated in anyway?

Yes it's not authenticated.

[guizmaii]

Ok I understand what's happening.

I configured this gem as follow:

Resque::Kubernetes.configuration do |config|
  config.environments = [ Rails.env ]
end

and it's not a good idea because if I only put ["production", "staging"], for example, the before_enqueue_kubernetes_job will return early enough in my test env to not generate these kind of problems because of this code:

# A before_enqueue hook that adds worker jobs to the cluster.
def before_enqueue_kubernetes_job(*_args)
  if defined? Rails
    return unless Resque::Kubernetes.environments.include?(Rails.env)
  end

   ...
end

Thanks for the quick answer and for your time. :)

[jeremywadsack]

Correct.

The reason for having config.environments was to have it explicitly exclude launching workers in test environment. You likely do not want to be changing any clusters when running tests (unless you have a specific staging environment that you would do that in.) Similarly, you probably don't want to launch workers in a cluster during development. I would suggest just production and staging as you have stated.

Resque::Kubernetes.configuration do |config|
  config.environments = %w[production staging]
end