search

keylimetoolbox / resque-kubernetes

Run Resque (and ActiveJob) workers as Kubernetes Jobs and autoscale from 0!
MIT License
54 stars 15 forks source link

Fix syntax #28

Closed will3216 closed 1 year ago

will3216 commented 3 years ago

Ruby 3 doesn't allow for the automatic expansion of hashes as the last argument of a function anymore. This just adds a minor change to expand an argument in the case of a ruby version that requires it.

will3216 commented 3 years ago

Wasn't exactly sure how to test this properly. If you have any suggestions I'm happy to implement them

jeremywadsack commented 3 years ago

Hi @will3216 Thanks for the PR. Is there a standard migration path for this deprecation that doesn't require checking the ruby version? Would the expectation be a fix in the upstream gem?

jeremywadsack commented 1 year ago

Closed in favor of #30