keylimetoolbox / resque-kubernetes

Run Resque (and ActiveJob) workers as Kubernetes Jobs and autoscale from 0!
MIT License
54 stars 15 forks source link

Do not reap pods; allow failed pods to remain for log inspection. #4

Closed jeremywadsack closed 6 years ago

jeremywadsack commented 6 years ago

Addresses #1.

When the pod reaper runs it removes all pods where pod.status.phase == "Succeeded". Apparently this includes pods that were OOMKilled. The Kubernetes docs state "When you delete the job using kubectl, all the pods it created are deleted too." So we no longer need to reap pods and if a pod fails we would like to have it around to inspect the logs and events.