search

keymanapp / keyboards

Open Source Keyman keyboards
138 stars 256 forks source link

bug(gff_sbs): missing pdf in documentation #2482

Closed mcdurdin closed 6 months ago

mcdurdin commented 6 months ago

gff_sbs/1.0.0/SBS-Typing-Manual.pdf is referenced but actually called SBS-Typing-English.pdf.

Detected in checks on https://github.com/keymanapp/help.keyman.com/pull/903

@dyacob

dyacob commented 6 months ago

Thanks, @mcdurdin, sorry... Addressed in #2483 .

In the course of the correction, I did now catch a small issue with KMD that I'll report, so that should be a plus.

LornaSIL commented 6 months ago

Can you also please remove the redundant word "Keyboard" in the name of the keyboard?

On Mon, Dec 4, 2023, 6:29 PM Daniel Yacob @.***> wrote:

Thanks, @mcdurdin https://github.com/mcdurdin, sorry... Addressed in

2483 https://github.com/keymanapp/keyboards/pull/2483 .

In the course of the correction, I did now catch a small issue with KMD that I'll report, so that should be a plus.

— Reply to this email directly, view it on GitHub https://github.com/keymanapp/keyboards/issues/2482#issuecomment-1839795357, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABV6RIYHUJ3WWTLRWMJWQALYHZTGDAVCNFSM6AAAAABAGZHQ7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZZG44TKMZVG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

dyacob commented 6 months ago

Thank you @LornaSIL , I adjusted it in the .kmn file, I believe that was the only place. LMK if there was another.