keymanapp / keyboards

Open Source Keyman keyboards
138 stars 256 forks source link

bug[itrans_bengali]: key v and b has the same output letter. #2542

Closed Meng-Heng closed 3 months ago

Meng-Heng commented 4 months ago

On the keyboard and documentation: image

The expected outputs: image

Only v is incorrect.

Original post - https://community.software.sil.org/t/output-character-not-displaced-by-the-key/8402

LornaSIL commented 4 months ago

2400 should be addressed at the same time as this one.

jayaradhakrishna commented 4 months ago

As suggested by someone in some other thread I request this to be in Pull-request.

My suggestion is to change different output letter for two different keys v and b.

There is no need to have the current keys v and b having the same output letter ব্

I suggest the following:

Option 1 v should give the output as ৎ as stated for the Special Bengali Sign b should give the output as ব্ B should give the output as ভ্

Option 2 b should give the output as ৎ as stated for the Special Bengali Sign v should give the output as ব্ V should give the output as ভ্

Option 3 _ should give the output as ৎ Let keys v and b have the same output letter ব্

jayaradhakrishna commented 4 months ago

Any progreess regarding this
https://community.software.sil.org/t/output-character-not-displaced-by-the-key/8402

mcdurdin commented 4 months ago

Any progreess regarding this https://community.software.sil.org/t/output-character-not-displaced-by-the-key/8402

We are working on it

jayaradhakrishna commented 4 months ago

Thank you so much for this.

I guess the bug is fixed and the next step is to fix the keyboard.

Jaya Radhakrishna dasa

On Mon, Feb 12, 2024 at 4:03 AM Marc Durdin @.***> wrote:

Any progreess regarding this

https://community.software.sil.org/t/output-character-not-displaced-by-the-key/8402

We are working on it

— Reply to this email directly, view it on GitHub https://github.com/keymanapp/keyboards/issues/2542#issuecomment-1937896329, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGA4W24A2VACUFIG3LJJHFDYTFBM5AVCNFSM6AAAAABC7FMWP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZXHA4TMMZSHE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

jayaradhakrishna commented 4 months ago

Do we need to download the new keyboard since the bug is fixed now?

LornaSIL commented 4 months ago

2545 hasn't been approved yet. There is one more action that needs doing before it can be approved. Once it's approved and merged then I think it will automatically be offered to anyone who has installed the keyboard from the Keyman site.

mcdurdin commented 4 months ago

Yes, once the fix is approved and merged, it will be distributed via an automatic update within a few days. You can check for keyboard updates or manually update it once it has been merged. The new version of the keyboard will be 1.0.2.

jayaradhakrishna commented 4 months ago

Thank you all so much for this. Great to see that it was updated nicely.

jayaradhakrishna commented 4 months ago

Great to see that it was updated. Thank you all.

Sincerely, Jayaradhakrishna dasa

On Thu, Feb 15, 2024 at 4:37 AM Marc Durdin @.***> wrote:

Yes, once the fix is approved and merged, it will be distributed via an automatic update within a few days. You can check for keyboard updates or manually update it once it has been merged. The new version of the keyboard will be 1.0.2.

— Reply to this email directly, view it on GitHub https://github.com/keymanapp/keyboards/issues/2542#issuecomment-1944948393, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGA4W26HCWHHH65JMR4CZDDYTU7S7AVCNFSM6AAAAABC7FMWP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBUHE2DQMZZGM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

LornaSIL commented 3 months ago

Fixed by #2545