[SIL Ethiopic] Add On-Screen keyboard in v2.0.5

keymanapp / keyboards

Open Source Keyman keyboards

138 stars 256 forks source link

[SIL Ethiopic] Add On-Screen keyboard in v2.0.5 #2827

Closed dyacob closed 1 week ago

dyacob commented 1 week ago

Minor revisions to the SIL Ethiopic keyboard to include an on-screen keyboard and the inclusion of the Abyssinica SIL font in the distribution.

On-Screen keyboard added.
AbyssinicalSIL-Regular.ttf added to package.
Upgrade project to Keyman Developer 17.0 format.

Following the successful merge of this PR, I'll follow up with a submission of the equivalent revisions to SIL Ethiopic Power-G.

keyman-server commented 1 week ago

Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly.

LornaSIL commented 1 week ago

I think the .kvk needs to be added to the files in the .kps.
I'm not sure why the .js is in the files in the .kps. Generally that's only there for a mobile layout. However, I hesitate to say remove it in case there's a regression in behavior.
The font was added to the list of files in the .kps, but it needs to be selected in the Keyboards tab in the .kps.

keyman-server commented 1 week ago

Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly.

keyman-server commented 1 week ago

Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly.

keyman-server commented 1 week ago

Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly.

dyacob commented 1 week ago

Thanks @LornaSIL , I have addressed the bullets and tested.

On the .js file, I have no added thoughts on how it might be used. I checked and saw that it is included in the current version (2.0.4), so I guess it is safest to leave it unchanged.