search

keymanapp / keyboards

Open Source Keyman keyboards
138 stars 256 forks source link

[sil_tchad_qwerty] Submit first version of sil_tchad_qwerty keyboard #2841

Closed jeffheath-sil closed 1 day ago

jeffheath-sil commented 4 days ago

Positional QWERTY version of the sil_tchad keyboard

keyman-server commented 4 days ago

Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly.

keyman-server commented 3 days ago

Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly.

LornaSIL commented 3 days ago

Thanks for your pull request. Most things look in order although I haven't done a real review. I did notice you included the AndikaAfr-R.ttf font. We are wanting people to use the \shared\ fonts when possible so that we don't have different versions of the same fonts floating around in various keyboard folders. So, that font is in this folder release\shared\fonts\sil\andika_subsets. If you don't have the whole repo cloned you could just edit the .kps file to change the path to <Name>..\..\..\shared\fonts\sil\andika_subsets\AndikaAfr-R.ttf</Name> (look in your sil_tchad project).

So, you should delete the AndikaAfr-R.ttf font from the PR and change the path in the .kps. Once we do a review we may find other issues.

jeffheath-sil commented 3 days ago

We are using the GitHub web interface (not wanting to download the whole 2GB keyboards repo), and there doesn't seem to be a way to delete files. Could someone please remove AndikaAfr-R.ttf from this PR? We will be submitting the change to the .kps file to point to the shared fonts folder.

keyman-server commented 3 days ago

Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly.

keyman-server commented 3 days ago

Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly.

DavidLRowe commented 2 days ago

@jeffheath-sil Normally, you can click on the three dots, then pick "Delete file" image

Does that work for you?

jeffheath-sil commented 2 days ago

Does that work for you?

No, it was greyed out for me (just like it was on your screen shot).

DavidLRowe commented 2 days ago

Oh, I see you created the pull request from your master branch. I wonder if that's why GitHub disables deleting files from the branch.

It's not an elegant solution, but closing this pull request and creating a new one with these files (minus the .ttf) is probably the easiest solution. We do recomment creating a branch and basing the pull request on the changes to that branch. (See https://help.keyman.com/developer/keyboards/github/step-3 for details.)

DavidLRowe commented 2 days ago

An additional change to consider for the README.md file: We recommending removing the "Version" line and the Copyright line (or at least the date range in the copyright line) from this file. This avoids the necessity to update the README.md file every time the keyboard changes.

jeffheath-sil commented 1 day ago

I'm considering doing what David R suggested, closing this PR, and opening a new one. So please don't process this one yet... (I had created a branch, but there was quite a bit of back and forth at the beginning and apparently my fork shifted to the master branch before I added the files. That may have been the problem with not being able to submit a whole folder with sub-folders as well...)

keyman-server commented 1 day ago

Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly.