search

keymanapp / keyboards

Open Source Keyman keyboards
138 stars 256 forks source link

docs: Add an explanation about the TeamCity build error when submitting pull requests #2844

Open sku21 opened 1 week ago

sku21 commented 1 week ago

Is your feature request related to a problem? Please describe.

It was a little confusing when I submitted my first pull request and immediately saw that I failed 1 of 2 checks when git processed my request. While I knew that the team would review my request, I wanted to know why I'd failed the check / if there was anything I needed to do to fix it. But trying to click on the "Details" link only brought me to a login page for TeamCity, so I couldn't view any of the information for the error.

Describe the solution you'd like

Adding a small bit of text to the Pull Request Tutorial about the error and/or adding it to the comment left by keyman-server on the request itself would be helpful. Even something simple like "TeamCity will automatically fail to build, but this is a default behavior. The Keyman team will manually create the build when they review your request." ...would be helpful.

Describe alternatives you've considered

No response

Related issues

No response

Keyman apps

Keyman version

No response

Operating system

No response

Device

No response

Target application

github.com

Browser

No response

Keyboard name

No response

Keyboard version

No response

Language name

No response

Additional context

No response

ermshiperete commented 1 week ago

Do you have a link to the PR?

Usually the text "This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR." is added if a PR is from an outside contributor and can't be built automatically.

sku21 commented 4 days ago

Do you have a link to the PR?

Usually the text "This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR." is added if a PR is from an outside contributor and can't be built automatically.

Yep, here's the link: https://github.com/keymanapp/keyboards/pull/2835 This is all that keyman-server comments, and then the following error appears: image image

ermshiperete commented 3 days ago

Moved from keyman to keyboards repo

LornaSIL commented 3 days ago

@ermshiperete I think this is a regression. It used to have the text you quoted, but it doesn't anymore. Changing this text isn't something we can do, it has to be something done by the developers.