bug(naijatype): custom CSS is too broad and impacts sites badly

[mcdurdin]

The naijatype keyboard has the following in its associated CSS:

body {
    background: rgb(193, 194, 193);
    font-family: "Andika","DejaVu Sans","AndikaAfr","Andika Afr","Andika New Basic Compact";
}

https://github.com/keymanapp/keyboards/blob/03b932e9b9558b6885534d31934084d00e88a6ef/experimental/n/naijatype/source/naijatype.css#L6-L9

Originally posted by @jahorton in https://github.com/keymanapp/help.keyman.com/issues/1272#issuecomment-2298050379

The CSS rules need to be restricted to the keyboard elements.

(Note, a future update of KeymanWeb may use 'shadow dom' to prevent this kind of style leakage, see keymanapp/keyman#4881)

[jahorton]

There is another issue with the keyboard's contents: https://github.com/keymanapp/keyboards/issues/3043

[LornaSIL]

Did the changes we made in naijatype make any difference? I notice it looks somewhat different, but it's still ugly. Most of the keyboards using this feature look ugly, except for sil_euro_latin so I think there must be other issues that need to be handled in the htm file.

[mcdurdin]

I notice it looks somewhat different, but it's still ugly.

I'm not sure what you are looking at? The two websites look fine now?

Help site:

Search result:

[LornaSIL]

Ok, I was looking at the keymanweb page.

On Fri, Aug 23, 2024, 8:01 PM Marc Durdin @.***> wrote:

I notice it looks somewhat different, but it's still ugly.

I'm not sure what you are looking at? The two websites look fine now?

Help site:

image.png (view on web) https://github.com/user-attachments/assets/6eee7be7-d561-44ae-9622-4d6b9a707e5b

Search result:

image.png (view on web) https://github.com/user-attachments/assets/71091f0e-320a-4fac-8965-ec1bbae0b36a

— Reply to this email directly, view it on GitHub https://github.com/keymanapp/keyboards/issues/3039#issuecomment-2307967704, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABV6RI5ZOSVLRDP6ZQUDPWTZS7LPZAVCNFSM6AAAAABMZ3IHL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBXHE3DONZQGQ . You are receiving this because you commented.Message ID: @.***>

[mcdurdin]

On keymanweb.com:

[LornaSIL]

I don't like the bullets leaking off the left side of the page. But, most other keyboards using this feature look the same. Is this issue fixed? Can we close it?

[mcdurdin]

Is this issue fixed? Can we close it?

Yes. I am tracking the formatting of the hosted kmw_helpfile content separately in keymanapp/keyman#12292