search

keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
386 stars 107 forks source link

[developer] KeymanWeb compiler needs to optimise static stores #1007

Open mcdurdin opened 6 years ago

mcdurdin commented 6 years ago

When compiling a keyboard with repeated platform statements, this generates many repeated stores. For an example, see https://github.com/silcam/Cameroon-Keyboard/blob/BrokenRules/src/km/cameroon_qwerty/source/cameroon_qwerty.kmn

If repeated stores are not used as a variable store, then they should be optimised to a single reference at compile time.

MattGyverLee commented 6 years ago

Just a note, those platform stores were only needed to avoid KM9's RALT/CAPS limitation. I'm not saying you don't need to fix it, but I'm removing 98% of the platform statements with a move to KM10.

mcdurdin commented 6 years ago

Yeah, I appreciate that for this specific keyboard it may not be such an issue in the future. :)

MattGyverLee commented 11 months ago

My keyboards no longer "spam" the platform statements. If you were holding this issue open for me, you can probably close it.

mcdurdin commented 11 months ago

It's not specific to your keyboards @MattGyverLee; it's a general optimization that we should do one day.