bug(web): Output of wrong characters when typing on Armenian legacy OSK

keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web

https://keyman.com/

Other

377 stars 104 forks source link

bug(web): Output of wrong characters when typing on Armenian legacy OSK #10140

Closed ermshiperete closed 6 months ago

ermshiperete commented 6 months ago

When using KeymanWeb with the legacy keyboard armenian.js, typing on the OSK outputs the en-US characters instead of the characters on the OSK. When using the hardware keyboard with the OSK the output is correct.

Happens with stable and alpha versions of Keyman (Keyman 16 and 17)

mcdurdin commented 6 months ago

Works in 12.0.106. https://keymanweb.com/?version=12.0.106#hy,Keyboard_armenian
Works in 13.0.111. https://keymanweb.com/?version=13.0.111#hy,Keyboard_armenian
Broken in 14.0. https://keymanweb.com/?version=14.0.294#hy,Keyboard_armenian

This seems to me to be a significant bug that we should be addressing if possible in 17.0 cycle. Can we discuss? It's probably not a difficult fix.

bisect gives breakage in 14.0.52-alpha. Relevant history:

refactor(web/engine): precomputation for OSK key events, headless production thereof (#2969)
refactor(web/engine): initial ModelManager split (#2974)
refactor(web/engine): LMLayer enablement state management rework (#2975)
refactor(web/engine): predictive data routing, LanguageProcessor as EventEmitter (#2976)
refactor(web/engine): web-core build prep (#2982)

So I am guessing #2969 broke this.

ermshiperete commented 6 months ago

It looks like this got fixed with #10141 (alpha) and #10177 (stable).

bharanidharanj commented 6 months ago

Tested this as per @ermshiperete suggestion and here is my observation: 1. In KeymanWeb 17.0.227 alpha build, typing on both OSK and Physical keyboard produces the correct output.

..KeymanWeb Alpha build

In KeymaWeb 16.0.144 Stable build, typing with the help of OSK shows the English characters. Whereas, If I use the physical keyboard for typing, it shows the armenian letters. Seems to be an issue in the Stable build.

..KeymanWeb Stable build

ermshiperete commented 6 months ago

@bharanidharanj Did you test the stable build with the test page from #10177 (https://build.palaso.org/repository/download/Keymanweb_TestPullRequests/428624:id/testing/unminified.html)? (since we build stable only when we do a release, 16.0.144 doesn't have the fix yet)

mcdurdin commented 6 months ago

@bharanidharanj Did you test the stable build with the test page from #10177 (https://build.palaso.org/repository/download/Keymanweb_TestPullRequests/428624:id/testing/unminified.html)?

I just tested with this build and verified it works correctly.