keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
391 stars 108 forks source link

bug(web): backspace key (special key) is different compared to return key #10263

Closed MayuraVerma closed 9 months ago

MayuraVerma commented 9 months ago

Describe the bug

Backspace do not have confirmation on tap, similar to how it is done for Return key. Even though both are same key type, special.

https://github.com/keymanapp/keyman/assets/14062593/34268b93-157d-4e40-aa7a-f76d5e64da68

Reproduce the bug

No response

Expected behavior

Backspace show confirmation by flashing special key active status on tap.

Related issues

No response

Keyman apps

Keyman version

17.0.229

Operating system

No response

Device

No response

Target application

No response

Browser

No response

Keyboard name

No response

Keyboard version

No response

Language name

No response

Additional context

No response

jahorton commented 9 months ago

Is your issue about how the BKSP key doesn't get highlighted while held? Is that what you mean by "confirmation"?

If so, this is consistent with how things worked with 16.0. Not saying that it's not something to change... just noting that it's not a regression - it "didn't break" due to the gesture rework.

MayuraVerma commented 9 months ago

Is your issue about how the BKSP key doesn't get highlighted while held? Is that what you mean by "confirmation"?

If so, this is consistent with how things worked with 16.0. Not saying that it's not something to change... just noting that it's not a regression - it "didn't break" due to the gesture rework.

Return shows confirmation of tapping by highlighting/changing the key color in blue color

backspace doesn’t have any confirmation.

MayuraVerma commented 9 months ago

K_LOPT, K_ENTER and K_BKSP all should have confirmation when touched.