search

keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
377 stars 104 forks source link

bug(common): sentry is injecting boilerplate into .d.ts files? #10490

Closed mcdurdin closed 5 months ago

mcdurdin commented 5 months ago 
!function(){try{var e="undefined"!=typeof window?window:"undefined"!=typeof global?global:"undefined"!=typeof self?self:{},n=(new Error).stack;n&&(e._sentryDebugIds=e._sentryDebugIds||{},e._sentryDebugIds[n]="efd73433-f1ea-5b91-9e57-c90d1baad20c")}catch(e){}}();

See e.g: common/web/types/build/src/util/compiler-interfaces.d.ts

This seems to be happening during kmc's build.sh bundle step.

mcdurdin commented 5 months ago

Looks like the following command should be tweaked:

https://github.com/keymanapp/keyman/blob/0ebc5d6aab55c62863cc4dda878d01ce8900b65b/developer/src/kmc/build.sh#L118-L123

Remove --ext ts. It was copied from the sentry-cli sourcemaps upload pattern. Verified that the map files seem to still be okay after calling this but shouldn't be there either.