chore(core): rename Uni_IsSMP to Uni_NonBMP

keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web

https://keyman.com/

Other

391 stars 109 forks source link

chore(core): rename Uni_IsSMP to Uni_NonBMP #10654

Open srl295 opened 8 months ago

srl295 commented 8 months ago

Suggest to rename Uni_IsSMP() to Uni_IsNonBMP() across unicode.h and kmcompx.h as it is misleading. The SMP is exactly U+10000..U+1FFFF only. Only used in a few places.

Discussed this at #10557.

mcdurdin commented 8 months ago

Yes my bad, back in probably 1998. SMP stands for Some More Planes and covers everything that is not in the BMP. Doesn't it?

mcdurdin commented 8 months ago

To be honest, the name is still ambiguous: what data type does it accept? I guess it takes a USV (u)int32t but... that's different to some of the other `Uni` macros.

The Uni_ class of macros in unicode.h could all be reviewed for better names.