search

keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
402 stars 112 forks source link

bug(developer): sourcemaps for app/ internal http server pages do not have correct paths #10811

Open mcdurdin opened 9 months ago

mcdurdin commented 9 months ago

These are not working for app/ sourcemaps; I will turn this into a separate issue:

image

We should re-test for kmc sourcemaps.

Originally posted by @mcdurdin in https://github.com/keymanapp/keyman/issues/10798#issuecomment-1958903057

mcdurdin commented 9 months ago

The Keyman Developer webviews do really need consolidation -- moving them to the Node server host. This will happen in a future version. For now, here are notes on paths for various webviews, and clearly we need to be careful for rewrites. I have marked those which appear to have a correct sourcemap with ✅ and those with incorrect paths with ❌ (and the diff)

Common shared paths

✅ /app/lib/sentry/bundle.min.js ✅ /app/lib/sentry/init.js

Project view

❌ /app/project/res/common.js ➡ /project/common.js ❌ /app/project/res/project.js ➡ /project/project.js

Touch Layout Editor

❌ /app/source/toucheditor/lib/jquery-1.10.2.js ➡ /layoutbuilder/jquery-1.10.2.js ❌ /app/source/toucheditor/lib/jquery-ui/jquery-ui.js ➡ /layoutbuilder/jquery-ui/jquery-ui.js ❌ /app/source/toucheditor/lib/constants.js ➡ /layoutbuilder/constants.js ❌ /app/source/toucheditor/lib/builder.js ➡ /layoutbuilder/builder.js ❌ /app/source/toucheditor/lib/undo.js ➡ /layoutbuilder/undo.js ❌ /app/source/toucheditor/lib/prepare-key.js ➡ /layoutbuilder/preparekey.js ❌ /app/source/toucheditor/lib/subkeys.js ➡ /layoutbuilder/subkeys.js ❌ /app/source/toucheditor/lib/view-controls.js ➡ /layoutbuilder/view-controls.js ❌ /app/source/toucheditor/lib/platform-controls.js ➡ /layoutbuilder/platform-controls.js ❌ /app/source/toucheditor/lib/layer-controls.js ➡ /layoutbuilder/layer-controls.js ❌ /app/source/toucheditor/lib/builder-charmap.js ➡ /layoutbuilder/builder-charmap.js ❌ /app/source/toucheditor/lib/drag-drop.js ➡ /layoutbuilder/drag-drop.js ❌ /app/source/toucheditor/lib/cleanup.js ➡ /layoutbuilder/cleanup.js

Text Editor

✅ /app/lib/jquery/jquery-1.10.2.js ✅ /app/lib/monaco/min/vs/loader.js ✅ /app/lib/monaco/min/vs/editor/editor.main.js ✅ /app/lib/monaco/min/vs/editor/editor.main.nls.js ✅ /app/editor/language.keyman.js ✅ /app/editor/editor.js

mcdurdin commented 9 months ago

Given none of the affected files are minified or modified in the build, for now we can live with these discrepancies, because the source line numbers will still map; it's just a little inconvenient.

So I will mark this for retriage in 18.0.