keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web

https://keyman.com/

Other

367 stars 102 forks source link

fix(android): fixes kbd text zoom to prevent accessibility cross-effects #11281

Closed jahorton closed 1 week ago

jahorton commented 2 weeks ago

Fixes #11279. Fixes #11280. (By preventing the scenario.)

Reference: https://stackoverflow.com/a/49649302

Device text-size accessibility scaling appears to affect the WebView "text zoom" setting. Directly setting text-zoom to a specific value bypasses this and locks down our keyboards' font sizes.

User Testing

TEST_ACCESSIBILITY_FONT_EFFECTS: Using the Keyman app for Android, verify that system accessibility settings for fonts have no effect on the size of the in-app and system keyboards.

Note that you will need to force-quit the app after changing system settings in order to properly test this; the app only retrieves font-size data once, when first loaded.

keymanapp-test-bot[bot] commented 2 weeks ago

User Test Results

Test specification and instructions

✅ TEST_ACCESSIBILITY_FONT_EFFECTS (PASSED): Tested with the attached PR build (Keyman 17.0.311-beta-test-11281) on an Android 12 / API 31 emulator and here is my observation: 1. Opened the Android Font-Settings and increased the Font size to maximum. 2. Opened the Keyman In-App and verified that the keyboard font remained at the default size and did not change. 3. Closed Keyman app. 4. Changed the Android Font-settings to minimum size. Restarted Keyman In-app. Verified that the keyboard font size still appeared in the default size. Verified that the system accessibility settings for fonts had no effect on the size of the Keyman in-app. (notes)

Test Artifacts

Android

bharanidharanj commented 1 week ago

Test Results

TEST_ACCESSIBILITY_FONT_EFFECTS (PASSED): Tested with the attached PR build (Keyman 17.0.311-beta-test-11281) on an Android 12 / API 31 emulator and here is my observation: 1. Opened the Android Font-Settings and increased the Font size to maximum. 2. Opened the Keyman In-App and verified that the keyboard font remained at the default size and did not change. 3. Closed Keyman app. 4. Changed the Android Font-settings to minimum size. Restarted Keyman In-app. Verified that the keyboard font size still appeared in the default size. Verified that the system accessibility settings for fonts had no effect on the size of the Keyman in-app.

keyman-server commented 1 week ago

Changes in this pull request will be available for download in Keyman version 17.0.315-beta