keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
367 stars 102 forks source link

fix(linux): Improve detection of Gnome environment #11292

Closed ermshiperete closed 6 days ago

ermshiperete commented 1 week ago

This change improves the way we detect if we're running a Gnome based UI that needs it's keyboards installed under org.gnome.desktop.input-sources. We use the environment variable XDG_CURRENT_DESKTOP and check if it contains the word gnome. Additionally this change renames is_gnome_shell() to is_gnome_desktop().

Fixes #11225.

User Testing

Preparations

Tests

TEST_INSTALL:

keymanapp-test-bot[bot] commented 1 week ago

User Test Results

Test specification and instructions

Test Artifacts

bharanidharanj commented 1 week ago

Test Results

GROUP_FOCAL: Ubuntu 20.04 Focal with Gnome Shell and X11

bharanidharanj commented 1 week ago

Test Results

GROUP_NOBLE_WAYLAND: Ubuntu 24.04 Noble with Gnome Shell and Wayland

bharanidharanj commented 1 week ago

Test Results

GROUP_WASTA: Wasta 22.04 with Cinnamon

ermshiperete commented 6 days ago

@bharanidharanj Please run:

sudo apt update
sudo apt upgrade
sudo apt dist-upgrade

then try the installation again.

@keymanapp-test-bot retest GROUP_NOBLE_WAYLAND TEST_INSTALL

bharanidharanj commented 6 days ago

Test Results

GROUP_NOBLE_WAYLAND: Ubuntu 24.04 Noble with Gnome Shell and Wayland

keyman-server commented 6 days ago

Changes in this pull request will be available for download in Keyman version 18.0.25-alpha