ermshiperete commented 1 week ago

It seems some Ubuntu versions ignore the icon field and only use generic-icon, so this change adds that field. This will fix displaying the icon on newer Ubuntu versions. And since we keep the icon field it should still work everywhere else.

Fixes #11144.

User Testing

Preparations

The tests should be run on these Linux platforms:
- GROUP_NOBLE_WAYLAND: Ubuntu 24.04 Noble with Gnome Shell and Wayland
- GROUP_WASTA: Wasta 20.04 with Cinnamon
Install build artifacts of this PR
Reboot

Tests

TEST_ICON:

Download a .kmp file from keyman.com
Verify that the correct icon shows for the .kmp file in the file manager

keymanapp-test-bot[bot] commented 1 week ago

User Test Results

Test specification and instructions

✅ GROUP_NOBLE_WAYLAND: Ubuntu 24.04 Noble with Gnome Shell and Wayland

1 tests PASSED
- ✅ **TEST_ICON ([PASSED](https://github.com/keymanapp/keyman/pull/11295#issuecomment-2085434341))**: Tested with the attached PR build (17.0.14-beta (package version 17.0.314-1~PR-11295-2783.1+noble1) ) on Ubuntu Noble 24.04 Linux OS (VM) and here is my observation: 1. Downloaded Khmer_Angkor and SIL (IPA) keyboards. 2. Verified that the correct icon appears for the corresponding .kmp files in the file manager. FYI, it is showing a blank icon in the Firefox Download list. ([notes](https://github.com/keymanapp/keyman/pull/11295#issuecomment-2085434341))
✅ GROUP_WASTA: Wasta 20.04 with Cinnamon

1 tests PASSED
- ✅ **TEST_ICON ([PASSED](https://github.com/keymanapp/keyman/pull/11295#issuecomment-2077469890))**: Tested with the attached PR build (Keyman 17.0.314-1~PR-11295-2783.1+focal1) on Wasta 22.04 Linux OS and here is my observation: 1. Downloaded Khmer_Angkor and SIL (IPA) keyboards. 2. Verified that the correct icon appears for the corresponding .kmp files in the file manager. ([notes](https://github.com/keymanapp/keyman/pull/11295#issuecomment-2077469890))

Test Artifacts

Linux

bharanidharanj commented 1 week ago

GROUP_WASTA: Wasta 20.04 with Cinnamon

TEST_ICON (PASSED): Tested with the attached PR build (Keyman 17.0.314-1~PR-11295-2783.1+focal1) on Wasta 22.04 Linux OS and here is my observation: 1. Downloaded Khmer_Angkor and SIL (IPA) keyboards. 2. Verified that the correct icon appears for the corresponding .kmp files in the file manager.

bharanidharanj commented 1 week ago

Test Results

GROUP_NOBLE_WAYLAND: Ubuntu 24.04 Noble with Gnome Shell and Wayland

TEST_ICON (BLOCKED): 1. Got an error message while installed the attached PR build on Ubuntu Noble_Wayland Linux OS. 2. This error prevents further testing on this test.

ermshiperete commented 1 week ago

@bharanidharanj What command do you use to install? I just tried with sudo apt install ./*.deb and that succeeded. Also, make sure you have all updates installed before trying to install Keyman (sudo apt update && sudo apt upgrade). Ubuntu 24.04 Noble got released yesterday - there have been a lot of changes in the last weeks leading up to the release.

bharanidharanj commented 1 week ago

@bharanidharanj What command do you use to install? I just tried with sudo apt install ./*.deb and that succeeded. Also, make sure you have all updates installed before trying to install Keyman (sudo apt update && sudo apt upgrade). Ubuntu 24.04 Noble got released yesterday - there have been a lot of changes in the last weeks leading up to the release.

@ermshiperete Here, What I did is: 1. Downloaded the PR build. 2. Opened it with terminal window. 3. Run the command to install the PR build and getting the above mentioned error message.

ermshiperete commented 1 week ago

@bharanidharanj ah, ok. Found the problem. Please run:

sudo apt update
sudo apt upgrade
sudo apt dist-upgrade

then try the installation again.

ermshiperete commented 1 week ago

@keymanapp-test-bot retest GROUP_NOBLE_WAYLAND TEST_ICON

bharanidharanj commented 6 days ago

Test Results

GROUP_NOBLE_WAYLAND: Ubuntu 24.04 Noble with Gnome Shell and Wayland

TEST_ICON (PASSED): Tested with the attached PR build (17.0.14-beta (package version 17.0.314-1~PR-11295-2783.1+noble1) ) on Ubuntu Noble 24.04 Linux OS (VM) and here is my observation: 1. Downloaded Khmer_Angkor and SIL (IPA) keyboards. 2. Verified that the correct icon appears for the corresponding .kmp files in the file manager. FYI, it is showing a blank icon in the Firefox Download list.

..icon appears correctly in the Downloads window