jahorton commented 2 weeks ago

Amother notable task I identified while working on https://github.com/keymanapp/keyman/pull/11300 (toward resolving https://github.com/keymanapp/keyman/issues/10497) is that a number of our packages have considerably out-of-date @types/node dependencies. The testing framework we'll likely be transitioning to includes a dependency of its own that requires a more recent version than some of the packages currently utilize... including the one installed in our monorepo root package.

Re: @types/node updates: https://stackoverflow.com/a/52404327

Put simply, the type of the typings package should match that of node. As we're currently on Node 18, I updated to the latest v18 typings. If we shift to 20 (or higher) before this lands, this should be updated again.

Note: I believe I did leave a few package-specific @types/node dependencies in place. If a package used something more recent than v18, I left it untouched in case there's something v20-specific that is relevant.

Fun(?) fact: tsc loads all @types/ packages in node-modules when compiling, regardless of whether or not they're actually relevant to the code being compiled. This fact was breaking builds once I started to use the upcoming test framework.

@keymanapp-test-bot skip

keymanapp-test-bot[bot] commented 2 weeks ago

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

Android
Developer
iOS
- Keyman for iOS (simulator image)
- FirstVoices Keyboards for iOS (simulator image)
- TestFlight internal PR build version - 18.0.30 (0.11319.10935)
Keyboards
- Test Keyboards
Linux
macOS
- Keyman for macOS
Web
- KeymanWeb Test Home
Windows

keyman-server commented 3 days ago

Changes in this pull request will be available for download in Keyman version 18.0.36-alpha

keymanapp / keyman

chore(web): updates most @types/node dependencies, makes them consistent 🏃 #11319

User Test Results

Test Artifacts