search

keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web
https://keyman.com/
Other
372 stars 102 forks source link

bug(android): Khmer predictive texts flashes on the suggestion banner after disabling the Predictions feature #11335

Open bharanidharanj opened 2 weeks ago

bharanidharanj commented 2 weeks ago

Describe the bug

After disabling the Predictions feature for the Khmer Angkor keyboard, I noticed that the Khmer_Angkor predictive text flashes on the suggestion bar when switching keyboards.

Reproduce the bug

  1. Install Keyman 18.0.25-alpha build.
  2. Open Keyman In-App.
  3. Download and install Khmer_Angkor keyboard.
  4. Switch to Khmer Angkor Keyboard.
  5. Verify the Khmer_Angkor predictive texts appear on the suggestion banner.
  6. Open the Installed Languages / Central Khmer (Khmer, Cambodia) Settings menu.
  7. Disable Predictions.
  8. Revert to home page.
  9. Verify the Keyman banner displays on the suggestion bar.
  10. Switch to 'sil_eurolatin' default keyboard.

Here, I noticed that the khmer_angkor predictive text briefly appears on the suggestion bar when switching keyboards.

I have attached the Video file for reference.

https://github.com/keymanapp/keyman/assets/19683143/fc836995-221b-4932-9e69-53687ec061b7

Expected behavior

Predictions that have been disabled should not be displayed on the suggestion bar.

Related issues

No response

Keyman apps

Keyman version

18.0.25-alpha

Operating system

Android 12, 13, 14

Device

API 34 emulator, Samsung Galaxy A23 Mobile device

Target application

No response

Browser

No response

Keyboard name

khmer_angkor

Keyboard version

1.3.1

Language name

Khmer

Additional context

No response

mcdurdin commented 2 weeks ago

@jahorton can you take a look at this one as well? Seems like the Khmer model is still in memory / being loaded when it has been disabled.

I don't think this needs to block 17.0 release, but I guess it indicates that something could be tidied up.

jahorton commented 2 weeks ago

I suppose it is something that could be tidied up, but it's probably not super-simple due to the structure for loading models.

I agree that this should not block 17.0 release. I severely doubt this was new to 17.0 - the structural patterns responsible have been in place since 14.0 if not 12.0.