bug(android): inverting text selection causes a crash

keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web

https://keyman.com/

Other

372 stars 102 forks source link

bug(android): inverting text selection causes a crash #11344

Closed mcdurdin closed 2 weeks ago

mcdurdin commented 2 weeks ago

https://github.com/keymanapp/keyman/assets/4498365/bface0fd-d14a-4b7a-b067-6ce074bc11cd

17.0.313-beta

https://keyman.sentry.io/share/issue/e7282fd7272c47f0bff964725f48ec7f/

from #11128

mcdurdin commented 2 weeks ago

Possibly related:

https://keyman.sentry.io/share/issue/7980e86e395b4c5cbd03ba03c98cfc0d/
https://keyman.sentry.io/share/issue/a08bf2d9be184cc9b6de5d0ae31b5924/

jahorton commented 2 weeks ago

I just triggered an instance matching the Sentry event from the description (automatically, no merge needed).

jahorton commented 2 weeks ago

Wait a second... yeah, something's off with that code. I'll throw something together real quick for it. selMin and selMax are defined, but go unused?

Looks like a merge conflict got incorrectly resolved, based on what was originally there in #11127.